From: Andreas Gruenbacher Subject: Re: Adding a security parameter to VFS functions Date: Fri, 17 Aug 2007 00:36:33 +0200 Message-ID: <200708170036.34276.agruen@suse.de> References: <29015.1187178055@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: torvalds@osdl.org, viro@ftp.linux.org.uk, sds@tycho.nsa.gov, casey@schaufler-ca.com, linux-fsdevel@vger.kernel.org, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org To: David Howells Return-path: In-Reply-To: <29015.1187178055@redhat.com> Content-Disposition: inline Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wednesday 15 August 2007 13:40, David Howells wrote: > > Hi Linus, Al, > > Would you object greatly to functions like vfs_mkdir() gaining a security > parameter? What I'm thinking of is this: > > int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, > struct security *security) > > Where the security context is the state of the context at the time the call > was issued: > > struct security { > uid_t fsuid; > git_t fsgid; > struct group_info *group_info; > void *security; > struct key *session_keyring; > struct key *process_keyring; > struct key *thread_keyring; > > And perhaps: > > struct audit_context *audit_context; > seccomp_t seccomp; > }; > > This would, for the most part, be a temporary affair, being set up by such > as sys_mkdir()/sys_mkdirat() from data held in task_struct. That's additional setup work unless that struct can be embedded in task_struct. We would be complicating the common / fast / local case to simplify the not-so-common case or cases. -- Andreas