From: Wolfgang Denk Date: Sun, 09 Sep 2007 01:09:17 +0200 Subject: [U-Boot-Users] [PATCH 5/5] OneNAND support In-Reply-To: Your message of "Fri, 07 Sep 2007 10:01:37 +0900." <20070907010137.GA20130@party> Message-ID: <20070908230917.C9ECB24653@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <20070907010137.GA20130@party> you wrote: > [PATCH] OneNAND support > > Signed-off-by: Kyungmin Park > --- > diff --git a/include/config_cmd_all.h b/include/config_cmd_all.h > index 3d91e99..f8eca87 100644 > --- a/include/config_cmd_all.h > +++ b/include/config_cmd_all.h > @@ -59,6 +59,7 @@ > #define CONFIG_CMD_NAND /* NAND support */ > #define CONFIG_CMD_NET /* bootp, tftpboot, rarpboot */ > #define CONFIG_CMD_NFS /* NFS support */ > +#define CONFIG_CMD_ONENAND /* OneNAND support */ NAK. CONFIG_CMD_ONENAND is definitely NOT a candiate for config_cmd_all.h > +++ b/include/onenand_uboot.h ... > +#define DEBUG_LEVEL 2 This should probably be 0 for production code? > +#ifdef ONENAND_DEBUG > +#define DEBUG(level, args...) \ > +do { \ > + if (level <= DEBUG_LEVEL) { \ > + printf(args); \ > + } \ > +} while (0) > +#else > +#define DEBUG(level, args...) do { } while (0) > +#endif Please do not reinvent yoru own debug macros, please use the existing ones instead. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "The X11 source code style is ATROCIOUS and should not be used as a model." - Doug Gwyn