From: Nick Piggin Subject: Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c Date: Mon, 17 Sep 2007 07:29:24 +1000 Message-ID: <200709170729.24835.nickpiggin@yahoo.com.au> References: <11900179463203-git-send-email-avi@qumranet.com> <46EE45C3.8040302@qumranet.com> <46EE4683.7070205@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <46EE4683.7070205-atKUWr5tajBWk0Htik3J/w@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Monday 17 September 2007 19:18, Avi Kivity wrote: > Avi Kivity wrote: > > Christoph Hellwig wrote: > >> On Mon, Sep 17, 2007 at 10:30:43AM +0200, Avi Kivity wrote: > >>> From: Nguyen Anh Quynh > >>> > >>> *nopage() in kvm_main.c should only store the type of mmap() fault if > >>> the pointers are not NULL. This patch fixes the problem. > >> > >> Care to convert it to ->faul while you're at it? > > > > I'll add this to my todo, though not sure It'll be in time for .24. If > > someone sends a patch I'll apply it. > > I should mention that the converting to use ->fault() is a 15-minute > change; the tricky part is adding backwards compatibility for the > external module package. It should be mostly possible to ifdef a nopage() handler, which is just a wrapper function to translate arguments then call your new ->fault() handler. With luck, fault would mostly inline into nopage, and do some constant folding to make it cheaper... I'm planning to go through and convert the rest of the in-tree users at some point soon, so if you do get a chance to convert your upstream code before I try, it would nice ;) Thanks, Nick ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/