From: Bastian Blank <bastian@waldi.eu.org>
Subject: Re: [PATCH] libfsimage: Make it build on NetBSD
Date: Sun, 23 Sep 2007 13:12:56 +0200
Message-ID: <20070923111256.GA10709@wavehammer.waldi.eu.org>
References: <200709211439.46415.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <200709211439.46415.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Fri, Sep 21, 2007 at 02:39:46PM +0200, Christoph Egger wrote:
> -  if (!*dirname || isspace (*dirname))
> +  if (!*dirname || isspace ((uint8_t)*dirname))

According to C99, the definition is "int isspace(int c)". Even char can
be converted implicitely to int. Which problem do you intend to fix with
that? If this functions are incorrectly defined on BSD, fix that their.

Bastian

-- 
The heart is not a logical organ.
		-- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4