From: Wolfgang Denk Date: Wed, 26 Sep 2007 00:12:03 +0200 Subject: [U-Boot-Users] [PATCH] Fpga: fix incorrect test of CFG_FPGA_XILINX macro In-Reply-To: Your message of "Tue, 25 Sep 2007 15:48:05 MDT." <20070925214558.4771.56775.stgit@trillian.cg.shawcable.net> Message-ID: <20070925221203.BA01A24835@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Grant, in message <20070925214558.4771.56775.stgit@trillian.cg.shawcable.net> you wrote: > > CFG_FPGA_XILINX is a bit value used to test against the value in > CONFIG_FPGA. Testing for a value will always return TRUE. I don't > think that is the intention in this code. > > Signed-off-by: Grant Likely > --- > > Wolfgang, this is a bug-fix only. It might be a good idea to go into > 1.3.0, but all I've done is compile tested it. I don't have any > hardware which is affected by this. I agree, it's an obvious fix. I will pull it into 1.3.0 ASAP. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Women professionals do tend to over-compensate. -- Dr. Elizabeth Dehaver, "Where No Man Has Gone Before", stardate 1312.9.