From: Wolfgang Denk Date: Wed, 26 Sep 2007 16:24:28 +0200 Subject: [U-Boot-Users] [PATCH] M18 flash (Sibley) support In-Reply-To: Your message of "Wed, 26 Sep 2007 15:55:02 +0400." <324c54a90709260455h7cc11fe9xa26f39402dcf34a0@mail.gmail.com> Message-ID: <20070926142428.A320D24769@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <324c54a90709260455h7cc11fe9xa26f39402dcf34a0@mail.gmail.com> you wrote: > > The following patch adds support of M18 flash in u-boot. > This flash has new command set (0x200) - so most changes in code are > related to dealing with it. The patch is verified on different kinds > of NOR using Mainstone II platform - no issues are found. ... > Hope to see this patch included (since M18 is widely used in > embedded). Any comments and suggestions are welcome. ... > static void flash_add_byte (flash_info_t * info, cfiword_t * cword, uchar c); > -static void flash_make_cmd (flash_info_t * info, uchar cmd, void *cmdbuf); > -static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, > uint offset, uchar cmd); ^^^^^^^^^^^^^^^^^^^^^^^^^ > +static void flash_make_cmd (flash_info_t * info, ulong cmd, void *cmdbuf); > +static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, > uint offset, ulong cmd); ^^^^^^^^^^^^^^^^^^^^^^^^^ > static void flash_unlock_seq (flash_info_t * info, flash_sect_t sect); > static int flash_isequal (flash_info_t * info, flash_sect_t sect, > uint offset, uchar cmd); ^^^^^^^^^^^^^^^^^^^^^^^^^ > static int flash_isset (flash_info_t * info, flash_sect_t sect, uint > offset, uchar cmd); ^^^^^^^^^^^^^^^^^^^^^^^^^ etc. Your patch was corrupted by your mailer which wrapped long lines. It cannot be applied. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Always try to do things in chronological order; it's less confusing that way.