From: Wolfgang Denk Date: Fri, 28 Sep 2007 22:28:04 +0200 Subject: [U-Boot-Users] [PATCH] tsec.c patch for receiver reset In-Reply-To: Your message of "Fri, 28 Sep 2007 10:24:17 PDT." <46FD38C1.3000205@fulcrummicro.com> Message-ID: <20070928202804.BAEA624769@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <46FD38C1.3000205@fulcrummicro.com> you wrote: > When we upgraded from u-boot 1.1.6 to 1.2.0, we found that ethernet no > longer worked reliably on our 8541-based platforms, although for some > reason 8548-based systems seemed to work fine. The problem was traced > to a missing assignment in function startup_tsec. We have tried this > patch on all of our 8541 and 8548-based boards, and it has resolved the > problem for us. > > Any comments or suggestions are greatly appreciated. > > Signed-off by: Alain Gravel > Signed-off by: Dan Wilson > ==================================================== > --- u-boot.git/drivers/tsec.c > +++ fulcrum/drivers/tsec.c > @@ -803,6 +803,7 @@ > /* Tell the DMA it is clear to go */ > regs->dmactrl |= DMACTRL_INIT_SETTINGS; > regs->tstat = TSTAT_CLEAR_THALT; > + regs->rstat = RSTAT_CLEAR_RHALT; > regs->dmactrl &= ~(DMACTRL_GRS | DMACTRL_GTS); > } Please indent by TABs, not spaces... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de They say a little knowledge is a dangerous thing, but it is not one half so bad as a lot of ignorance. - Terry Pratchett, _Equal Rites_