From: Steve Grubb Subject: Re: [PATCH] audit: clear thread flag for new children Date: Thu, 1 Nov 2007 10:33:52 -0400 Message-ID: <200711011033.53265.sgrubb@redhat.com> References: <20071026204228.GA1519@suse.de> <200710291804.31784.sgrubb@redhat.com> <20071029231529.GB15210@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20071029231529.GB15210@suse.de> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Tony Jones Cc: chrisw@sous-sol.org, linux-audit@redhat.com, linux-kernel@vger.kernel.org, viro@ftp.linux.org.uk List-Id: linux-audit@redhat.com On Monday 29 October 2007 07:15:30 pm Tony Jones wrote: > On Mon, Oct 29, 2007 at 06:04:31PM -0400, Steve Grubb wrote: > > So when audit is re-enabled, how do you make that task auditable? > > No idea. How do you do it currently? HINT: current->audit_context == NULL > for these tasks. If !audit_enabled, then audit_alloc() is not going to > allocate an audit_context for the task. We are looking into this - at one time it did. Someone should follow up with a path correcting this soon. But I doubt the audit system will work correctly if the flag gets removed as there is no good way to add it again later. -Steve