From: John Levon <john.levon@sun.com>
Subject: Re: [PATCH] Fix non-portable grep usage
Date: Tue, 13 Nov 2007 17:29:24 +0000
Message-ID: <20071113172924.GA19377@barman.uk.sun.com>
References: <695e38fa5029bafc9ee9.1194906281@hatchback>
	<18233.30225.421919.425668@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <18233.30225.421919.425668@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Tue, Nov 13, 2007 at 10:01:53AM +0000, Ian Jackson wrote:

> john.levon@sun.com writes ("[Xen-devel] [PATCH] Fix non-portable grep usage"):
> > -	  grep -E -q '^ +U ' && {                            \
> > +	  egrep '^ +U ' 2>/dev/null && {                     \
> 
> -q suppresses stdout output, not stderr.  So I think you mean:
>   +	  egrep '^ +U ' >/dev/null && {                      \

Right, thanks (I didn't see any output, obviously, so missed this)

regards
john