From: "Christoph Egger" Subject: Re: [PATCH][SVM] fix guest hang Date: Tue, 20 Nov 2007 16:29:02 +0100 Message-ID: <200711201629.02828.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Changeset 16398 is fine with me. Thank you for committing the fix. Christoph On Tuesday 20 November 2007 16:08:32 Keir Fraser wrote: > Good catch. Actually I think it is better to clear interrupt_shadow in > update_guest_eip. I did this, plus a few other cleanups as c/s 16398 in t= he > unstable staging tree. Please take a look and make sure I didn't screw up. > > Thanks, > Keir > > On 20/11/07 12:56, "Christoph Egger" wrote: > > Hi Keir! > > > > Attached patch fixes a boot hang we have seen with SLES 9.3 and FreeBSD > > HVM guests. Both are 32bit guests and run with a 64bit hypervisor. > > > > The patch does the following: > > 1) Cache current vcpu in svm_vmexit_do_hlt > > 2) Check for interrupt shadow in svm_vmexit_do_hlt and handle it like a > > pending interrupt > > > > The boot hang happens when the hlt is intercepted and the interrupt > > shadow field in vmcb is set, then the guest waits forever for the next > > timer interrupt. > > > > Change 1) is a cleanup, 2) is the fix > > > > Signed-off-by: Christoph Egger =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=E4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=E4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=E4ftsf=FChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy