Date: Sun, 9 Dec 2007 22:00:58 +0200
From: Dan Kenigsberg <danken@qumranet.com>
Subject: Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with
	x86's -cpu option
Message-ID: <20071209200058.GA2748@karma.qumranet.com>
References: <20071125132334.GA9555@karma.qumranet.com>
	<20071209030244.GC12436@networkno.de>
	<20071209092721.GA2858@karma.qumranet.com>
	<200712091136.36900.paul@codesourcery.com>
	<20071209135201.GA5113@karma.qumranet.com>
	<jesl2blo0y.fsf@sykes.suse.de>
	<20071209185834.GA2395@karma.qumranet.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071209185834.GA2395@karma.qumranet.com>
Reply-To: qemu-devel@nongnu.org
To: qemu-devel@nongnu.org

On Sun, Dec 09, 2007 at 08:58:34PM +0200, Dan Kenigsberg wrote:
> On Sun, Dec 09, 2007 at 07:29:49PM +0100, Andreas Schwab wrote:
> > Dan Kenigsberg <danken@qumranet.com> writes:
> > 
> > > +                x86_cpu_def->vendor1 = val[0] + (val[1] << 8)
> > > +                                     + (val[2] << 16) + (val[3] << 24);
> > > +                x86_cpu_def->vendor2 = val[4] + (val[5] << 8)
> > > +                                     + (val[6] << 16) + (val[7] << 24);
> > > +                x86_cpu_def->vendor3 = val[8] + (val[9] << 8)
> > > +                                     + (val[10] << 16) + (val[11] << 24);
> > 
> > That will do the wrong thing with the sign bit.
> > 
> 
> Please tell me when I'm done making a fool of myself.
> 

Apparently, I was not done. So I'll just shut up now.
Sorry for the noise.

Dan.