From: Jeff Dike Date: Thu, 17 Jan 2008 23:08:02 +0000 Subject: Re: [-mm Patch] uml: fix a building error Message-Id: <20080117230802.GA9360@c2.user-mode-linux.org> List-Id: References: <20080117105606.ff89e9e9.akpm@linux-foundation.org> <924EFEDD5F540B4284297C4DC59F3DEE5E90DF@orsmsx423.amr.corp.intel.com> <20080117211437.GA7573@c2.user-mode-linux.org> <20080117214150.GA25872@linux-os.sc.intel.com> In-Reply-To: <20080117214150.GA25872@linux-os.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Venki Pallipadi Cc: Andrew Morton , Mariusz Kozlowski , WANG Cong , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, David Miller , sparclinux@vger.kernel.org, Ingo Molnar , Thomas Gleixner On Thu, Jan 17, 2008 at 01:41:50PM -0800, Venki Pallipadi wrote: > > And while we're on the subject, what's the deal with these, in > > include/asm-x86/io.h? > > > > #define ioremap_wc ioremap_wc > > #define unxlate_dev_mem_ptr unxlate_dev_mem_ptr > > > > If archs want to override the defaults for these two functions, they define > the above and then include asm-generic/iomap.h. That wasn't really the question. #define X X is a no-op, yes? Jeff -- Work email - jdike at linux dot intel dot com