From: Jan Kara Subject: Re: [patch 25/26] mount options: fix udf Date: Fri, 25 Jan 2008 17:04:15 +0100 Message-ID: <20080125160415.GA1767@duck.suse.cz> References: <20080124193341.166753833@szeredi.hu> <20080124193456.220272889@szeredi.hu> <20080125153044.GF28856@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, gorcunov@gmail.com To: Miklos Szeredi Return-path: Received: from styx.suse.cz ([82.119.242.94]:57237 "EHLO duck.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753795AbYAYQER (ORCPT ); Fri, 25 Jan 2008 11:04:17 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri 25-01-08 16:56:13, Miklos Szeredi wrote: > > Please use just 'int' for 'remount' option. We are slowly trying to > > get rid of these strange things in UDF code so adding new ones isn't > > desirable. > > What's wrong with bool? > > I'm not advocating mass replacements, but all new code _should_ use > it, because it's a very useful and good type. > > We are just not very much used to it yet, but don't tell me it's > confusing to see a type like this ;) It's not so confusing but one really isn't used to it ;) But OK, I don't mind that much... Honza -- Jan Kara SUSE Labs, CR