From: "Mark Langsdorf" Subject: Re: [PATCH] Disable Xen PowerNow! support on Opteron 2nd gen and earlier processors Date: Fri, 25 Jan 2008 16:58:39 -0600 Message-ID: <200801251658.40027.mark.langsdorf@amd.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_gmmmHuAQRzvf/TJ" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Ian Pratt , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --Boundary-00=_gmmmHuAQRzvf/TJ Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wednesday 23 January 2008, Keir Fraser wrote: > On 23/1/08 22:34, "Ian Pratt" wrote: > > > Since we probably don't know how long we had to wait between when the > > multipler was increased and when the CPU was un-paused, it will be > > necessary to recalibrate the CPU to the global time source (PIT/HPET). > > Yes, actually that is a good point. Possibly we would get better results by > setting t->stime_local_stamp = t->stime_master_stamp = read_platform_stime() > in xen/arch/x86/time.c:cpu_frequency_change(). Currently we set the local > stamp to get_s_time(), but get_s_time() may not be trustworthy. I tried this suggestion and also implemented the trace function in cpu_frequency_change() and local_time_calibration() you suggested in a previous message. It made no discernable difference in my tests. I did high to low and low to high changes roughly every five minutes, and always got an excessive difference inside of Xen and usually got error messages in Linux. Changed code follows and the xm dmesg log is attached. diff -r 62fc84adc8ed xen/arch/x86/time.c --- a/xen/arch/x86/time.c Fri Jan 18 13:43:26 2008 +0000 +++ b/xen/arch/x86/time.c Fri Jan 25 16:45:03 2008 -0600 @@ -724,6 +724,20 @@ void update_domain_wallclock_time(struct spin_unlock(&wc_lock); } +void checktime(char *buf); +void checktime(char *buf) +{ + u64 s_tmp, p_tmp, diff; + s_tmp = get_s_time(); + p_tmp = read_platform_stime(); + if (s_tmp > p_tmp) + diff = s_tmp - p_tmp; + else + diff = p_tmp - s_tmp; + if (diff > 50000000) + printk(KERN_ERR "%s:time differed by %lu platform time %lu, systime %lu\n", buf, diff, p_tmp, s_tmp); +} + int cpu_frequency_change(u64 freq) { struct cpu_time *t = &this_cpu(cpu_time); @@ -732,11 +746,14 @@ int cpu_frequency_change(u64 freq) local_irq_disable(); rdtscll(curr_tsc); t->local_tsc_stamp = curr_tsc; - t->stime_local_stamp = get_s_time(); +// t->stime_local_stamp = get_s_time(); t->stime_master_stamp = read_platform_stime(); + t->stime_local_stamp = t->stime_master_stamp; set_time_scale(&t->tsc_scale, freq); +checktime("frequency_change"); local_irq_enable(); +printk(KERN_ERR "freq change at %lu\n", t->stime_master_stamp); /* A full epoch should pass before we check for deviation. */ set_timer(&t->calibration_timer, NOW() + EPOCH); if ( smp_processor_id() == 0 ) @@ -808,6 +825,7 @@ static void local_time_calibration(void rdtscll(curr_tsc); curr_local_stime = get_s_time(); curr_master_stime = read_platform_stime(); +checktime("calibration"); local_irq_enable(); #if 0 --Boundary-00=_gmmmHuAQRzvf/TJ Content-Type: application/x-gzip; name=xen_revf_time.log.gz Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=xen_revf_time.log.gz H4sICM5lmkcAA3hlbl9yZXZmX3RpbWUubG9nAKVYbXPbxhH+7l+xnXyIlIoU7gUHgB17SouyzVak VFFyk6k7KkQcJdQkwQBgbHX84/ssSJAgKCpIQo/5cth99nZv99k90d0dEf/fvu74tfnYf93tfln/ fEWf6NMpnbLS3QrxG38/LT/WouVTLH7DI/5efLkjvPMqkABFp6cQ/ETf81uBVXwWH4Vm8Y+fnha/ 7+7w+Z/1Eh4V2kA6LcD46UqDLRyvDB2zVTZdon26Y/Rv3+hotVQIFiqnr+DY6ae7T7zrUofjc3R3 zB+Fd3h4Uj7lNfxeL7XxC4uF9qvnQvq7Xq+OfjwfHtOPdk6/2DSLkzmptmot51ke3k8tHaVJkv81 nEXtcTI7pqOH8XgjqNuiLUk6jhFCuHS0SG1qpzbMLARHt6Nzuojny6/Hx/Qujelv4ZykS8LtaN3R is5GN6zrr3dwEeY2y+nsMZw/2JHNOxsl4ZNQ0OhIUyjQnx28SBjP1R0jJ2Nfh9HYt9Ea6SyZZwm2 nizzxTKnOKPsaT5+TJN5sszaG6HZLJxHNI3ntkPwTbyGD4A/8ecCvwuI17xeaN+tV2i8WE5S+/Pr KJk5rc82ndvpGvFjHNmE4vkkSWdhjvh01g/o4/su7yK3X3OaJZEl3/kq3ROaJPOc/K/CbATfnp/2 emc0s/ljEmUdmidz+xc67/V7lKfhPJvYlPJ4hh1Lyiz2FGWlbiHE1qGUU2rzNLa/2Iju7ThcZhar xNDrB+F0bYQim9txvgleL87GzzrxLlkiXIIGb68pix/mYb5MbVZ/et7rVbUpy9PluCqJRGtZXzp0 3R3QLFxs8J3ai1rVpSDysXS0zDgpj5/RWQns6IQFzBFs2xSReE5rbOuWhPOrWqK+v/HETlZaB/a3 EdjViQqd7tlVn6IwD59Vi+pqEyfYqg0/jp7RWotstaIypofdmthx3S1eUr+mZfe1bBGhl7QmE39X S5SPDmttRbZaaqO1G/jRU5bbGadYh7QT6MFbOtIikMi7z2+PK5T3aJGBJAoBoQNXbh/3klkYrySQ 0XEeh9M4s1GHeoMufYmj/JGUpPs4LzP7Kk3GNsuSlL5zmOUEda/6Zxuy3FR5RU40lJMN5dRLcv1L Xv+X8+8OhYt4fBdHpE+2Yt4JhVGE6GfkfC2z4YTej/rktIS7CyIqIO5LIGIDIkxLiV0UWUExL6HI DYqSLe2tUc7nOPN4/rDyl4m1AyKahnmb6DbjB4r6p5fF4/KQVuvZ+NFGy6lNOzQaXNFZaqM4p1G5 SkfjYmWTCmuKRPsKVNsIjwYf/keLMu5lS+kOejT6iJTrjvq9jKK4yMmoXfbYD/wMAmTnxYOyE13d Op1C+Xz+gG5kU97iKJwt0G6Qx4sF/3bkWvwt+jEvbMyTOBVk4wX5fGbbvXSYy9cROhN0Nk3Gn+ka sLww5Db03W+TFg39hEPiDzkkT+VzDv2aUfmHjKpT9XuMqt9g9CbJ0XeTCemt3YzCcR7/guEnKvPo fNh9e9EfvkeZtIrU7l//Y9NoW2/WOTy3X6h79vd1Gy+5ANnPzbcYElJKUFKTafIlA4ORVJr+G08m sd0MQTVxzCiq7XoBZ3fRXq4GdMNPyqClyfLhMaflAh7A96wSpv7lYHBbJtEmt3/44Qe6uOz22Jve 5aDbH5LDi6U3zMG0mqI6ZHQLdHpC0+z+hCeyRZirMnRMx87zkgvmCiaK9csv6IL7xJudVbScSJbT 5tWHn0b9s+4FDc4Hl9c/Uff6ujt8fz44H950dkyGU1RCG8SyaToyXH1pvdmsjMs2FPjGEwG29GAx 7yUYvlYAfLwlm3zsX9/cvmz5Igkj0E3pbt2z1psDXlEfjapNKcb1OPtcVfQLJq4qWhttE52uHp+y 1iAcPxYzGdXFKorC+FpONhZHeZjmxcjHMaKqmLun6OpQbywiRlTcMbJOTdHUFQO3slUuXRRXOP5c txjsWQxMRfHm8qZ70dncfLY+OvWoitXaZrQe3vBB9XrX56PR/nFsBwaHHsMMEfwaz5Yz1MjHSpHw 0aS4byDjna+m6K8n7AaiF+a1RBVb1NE4Xd7fc8G/S61djTTtCNeCsoa5hHA3GFu6X05wP0A0o90i HOVgrIvkYYr7ALLpPE0L2sG8/iVM54Aut/h+yTewreQwyR/Z8tE18rc1jWdxzgPQMwDH23r/Da9d Jfpn93oIoujQ2eVwdHlxTpe3N1e3N9Qf0ein4dmH68vh5e2opnTzCNZKFsVlI2aey+2cawfFF8Z8 u7lfPjywE6BdDtX9E9pvtmSiriHljzgHVOvz98bpE7CmMQgV4LCVP4LhwfcgdL5CtmtgH5IviCEo NacxrrDYVppESxzSqP9+2H8H6hneENjXzsfg4yKWIU5vnNc3Bfr9bC33kTb1i00NL29wiwM/zlae gsC5nQC9CALuen/6I6eh2u02SX4T/FYh8tHK3XjO0QG5gtBBefnTwtL3ZzfXF63we4SFs5R3XfBf 9iXOwSkrFfzGCZSpwumMG6ODibyYr9HIZkn6VAYyTorJ8IFT8u5LisxbzYqvUTWIxmuMrsk0uovT n/krmuHq6wvaLG5xDk+vi6oNJmKlt1kTvPYCQDfHpWJR+IFhM548bRo0NlQcQzxv8VUb/bo8Av5b AY2Lv2lwmZtABJ6ntCPd5wU8RwlP+Mo16qCAdHytlSl9HeNicp+uLusceJQ/8wBf/Z9w+5FaeI6H iaPa6wGj4a7CTBCAhXBdWi06ju8KV3oHd+d7AbOsGxwU8LXrajjQZHdKG18Exoj67oRyXWVAsLqy O8G7A/TB0AitfT8Af+qDAq50cSH0gya7M8oxxvHc+uakwiFp7Ri/sjmpjJHCEfrQ5mDYkx5u5o0i wz1A6kCYunElBQ4AtmTVuBa+9nHOphF24GiDY/bq2Foa5RsXzyvYSnG+Ovhsgi2kK9EV9R62qwLD HdozFWyXA8LX7kPp5HvaRym4spFx7biuQersJXuA4tYBwuNWjAfa8RzX1+KQ8UArATQROIcEkE3K R700K0XIIvOU2tsdWj48VNXQIPWN1BKpdmB3SHKfR0/40MS4hDfGxTRUM+47OBPpO54nqsa1cOEX mKjRmSugOEL4dWyhHZ/rzXgVbIEzF4HCsTc7Us9znYBn6l1s1BpmbbBNdd+oACeAq1I2qm9PK8+H fB1bgeaU7ypXVbBRY8pxDGrkALUL7WHCVTy/NToRPnFhdN0z4ASOZxx4XuEXg9NALnguOOSQfZS0 bzQYspH3KCrPVwjunn0PpSIClIes2md2RVoYVx6wL7Fx6fvcnl6QwOE4nmh09giPQnXucQlwPIl0 DnSVBMGI3CBQsaYZu0vF9evv+S+FHxhPoUMGO+iuBOMHRjZCFyBvhfPw69VuuKYl+ofr6So8Gp5A w8FyE3jkJtqm9OuNk7eJIwWPy53Ng8icIJBGNEtNtEluPnIPHYwI3sEQYKro6Pguzso7dPAYaFzX ccH14kDyFhLaANppFF50MM6BfaZH70EohfG86lwjAgHK0cqXjZqvcOGnh/Pb62JSCFg1AvSzA4/C Y3CnUSNQxnN96Zt65QNdBdySkPLV5o5JACuYRA6E1weNKReH4htxWIL5RCLOjRIA1O+j4OvpBRzm S2TpDu2CF8ANGFaaMQ8PYMh2tcfpWgWBwZzgec4OOjqI5DbcrK6FNibwvfrkBBwcK+ZDUHQVnVnT dQO40GjvoC9ExqmXBtADDNN4+TuRQaAwycLEgbEQUUAd82jiuQcaSyGi0I9QQY1Or/j7iUFB1vYI IB4rMMFjFNtukpNOGCwrqRvhC2BgbEC/ecaACTC2aM+vGdCYlDCcqUb8g3FT+IhxvfwAhJlM+gGG qGAHP8CtiK9NolEColMjmUA1z+D7qDRucrv7D0wAHxDTA80P47cB/6mAK+clEeQD0rPRNOviLoFy q+cx42hMUAFuCJVELpZdhdg7zVhIBhieMKvUM5mBwHCw4Rqzi4/EQnrjXtaoDrXASIIh7Rl8GEZJ oB/t4Ht8hQFPNTxENDXcTNTeeMBIGG1ksdMdA7jbIrPQqhp1ARcZjoqW9QGhwMeM6HoYYncdwHUF Wn4zKpG4ZmNsVvX7JYAwR4EV0A13AxQgJdAoHSle/R9nMaO+ciMAAA== --Boundary-00=_gmmmHuAQRzvf/TJ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_gmmmHuAQRzvf/TJ--