From: maximilian attems Subject: Re: sis190 build breakage Date: Wed, 30 Jan 2008 00:12:23 +0100 Message-ID: <20080129231223.GT1446@baikonur.stro.at> References: <20080129215023.GA24152@stro.at> <20080129220310.GC15445@electric-eye.fr.zoreil.com> <20080129222719.GS1446@baikonur.stro.at> <20080129222748.GD15445@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: Francois Romieu , Randy Dunlap Return-path: Received: from baikonur.stro.at ([213.239.196.228]:38314 "EHLO baikonur.stro.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbYA2XNy (ORCPT ); Tue, 29 Jan 2008 18:13:54 -0500 Content-Disposition: inline In-Reply-To: <20080129222748.GD15445@electric-eye.fr.zoreil.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 29, 2008 at 11:27:48PM +0100, Francois Romieu wrote: > maximilian attems : > [...] > > probably i should to get interesting info. > > Don't bother. > > $ less +/devinitdata Documentation/pci.txt > [...] > Tips on when/where to use the above attributes: > o The module_init()/module_exit() functions (and all > initialization functions called _only_ from these) > should be marked __init/__exit. > > o Do not mark the struct pci_driver. > > o The ID table array should be marked __devinitdata. > > Could our documentation be wrong ? yep that was what i had in mind, so i was a bit baffled.. randy any insight? > > diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c > index b570402..2e9e88b 100644 > --- a/drivers/net/sis190.c > +++ b/drivers/net/sis190.c > @@ -326,7 +326,7 @@ static const struct { > { "SiS 191 PCI Gigabit Ethernet adapter" }, > }; > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > +static struct pci_device_id sis190_pci_tbl[] = { > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, > { 0, }, thanks for quick fix.