From: Ingo Molnar Date: Thu, 31 Jan 2008 17:43:31 +0000 Subject: Re: sparc compile error caused by x86 arch updates Message-Id: <20080131174331.GA11881@elte.hu> List-Id: References: <20080130011550.GA31853@elte.hu> <20080131155739.GA19700@cs181133002.pp.htv.fi> <20080131160033.GA11501@elte.hu> <20080131161235.GB19700@cs181133002.pp.htv.fi> <20080131161523.GA12347@elte.hu> <20080131162920.GE19700@cs181133002.pp.htv.fi> <47A1FC6D.6090305@goop.org> In-Reply-To: <47A1FC6D.6090305@goop.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jeremy Fitzhardinge Cc: Adrian Bunk , wli@holomorphy.com, Linus Torvalds , linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , sparclinux@vger.kernel.org * Jeremy Fitzhardinge wrote: > But I guess I overlooked the comment... > > I guess the fix is to scatter linux/pagemap.h into the appropriate > places where these macros are used (asm-generic/tlb.h, for a start). no. The fix is always to undo the damage ASAP, to keep the window of breakage minimized. Adrian, could you please check whether latest x86.git: git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git resolves the Sparc build failure you were seeing? All known issues are fixed in it. (let me know if you know about more) Ingo