Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JLHMc-00040f-Jj for mharc-grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:54 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JLHMb-00040a-92 for grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JLHMZ-00040O-UJ for grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:51 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLHMZ-00040L-P3 for grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:51 -0500 Received: from ns39764.ovh.net ([91.121.25.85] helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JLHMZ-0002rK-Km for grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:51 -0500 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 5C1FB3EB26 for ; Sat, 2 Feb 2008 13:27:34 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 2 Feb 2008 13:20:49 +0100 User-Agent: KMail/1.9.4 References: <20080201200230.GA29932@thorin> In-Reply-To: <20080201200230.GA29932@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802021320.49710.okuji@enbug.org> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] don't display menu when there's nothing in it X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2008 12:20:53 -0000 On Friday 01 February 2008 21:02, Robert Millan wrote: > normal.mod seems to insist in displaying a menu even if grub.cfg didn't > define any menu entries. This seems to be due to a bogus check (for > menu instead of menu->size). It is not completely bogus, since MENU can be NULL. Probably what you want is: if (menu && menu->size) Okuji