From: David Miller Subject: Re: [IPV4]: route: fix crash ip_route_input Date: Thu, 07 Feb 2008 17:58:37 -0800 (PST) Message-ID: <20080207.175837.202612782.davem@davemloft.net> References: <47A9B7F9.3090808@trash.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org, den@openvz.org, netdev@vger.kernel.org To: kaber@trash.net Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58063 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751419AbYBHB6G (ORCPT ); Thu, 7 Feb 2008 20:58:06 -0500 In-Reply-To: <47A9B7F9.3090808@trash.net> Sender: netfilter-devel-owner@vger.kernel.org List-ID: From: Patrick McHardy Date: Wed, 06 Feb 2008 14:36:57 +0100 > [IPV4]: route: fix crash ip_route_input > > ip_route_me_harder() may call ip_route_input() with skbs that don't > have skb->dev set for skbs rerouted in LOCAL_OUT and TCP resets > generated by the REJECT target, resulting in a crash when dereferencing > skb->dev->nd_net. Since ip_route_input() has an input device argument, > it seems correct to use that one anyway. > > Bug introduced in b5921910a1 (Routing cache virtualization). > > Signed-off-by: Patrick McHardy Applied, thanks Patrick.