Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m17DLQH8022383 for ; Thu, 7 Feb 2008 08:21:26 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by mx3.redhat.com (8.13.1/8.13.1) with ESMTP id m17DL39l017617 for ; Thu, 7 Feb 2008 08:21:03 -0500 Date: Thu, 7 Feb 2008 11:20:23 -0200 From: Mauro Carvalho Chehab To: Brandon Philips Message-ID: <20080207112023.27870246@gaivota> In-Reply-To: <20080205234356.GA29915@plankton.ifup.org> References: <20080205234356.GA29915@plankton.ifup.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: v4l-dvb-maintainer@linuxtv.org, Guennadi Liakhovetski , video4linux-list@redhat.com Subject: Re: [PATCH 2 of 3] [v4l] Add new user class controls and deprecate others List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: On Tue, 5 Feb 2008 15:43:56 -0800 Brandon Philips wrote: > On 11:03 Tue 05 Feb 2008, Guennadi Liakhovetski wrote: > > On Mon, 4 Feb 2008, Brandon Philips wrote: > > > > > + > > > +/* Deprecated, use V4L2_CID_PAN_RESET and V4L2_CID_TILT_RESET */ > > > +#define V4L2_CID_HCENTER_DEPRECATED (V4L2_CID_BASE+22) > > > +#define V4L2_CID_VCENTER_DEPRECATED (V4L2_CID_BASE+23) > > > + > > > +#define V4L2_CID_POWER_LINE_FREQUENCY (V4L2_CID_BASE+24) > > > +enum v4l2_power_line_frequency { > > > + V4L2_CID_POWER_LINE_FREQUENCY_DISABLED = 0, > > > + V4L2_CID_POWER_LINE_FREQUENCY_50HZ = 1, > > > + V4L2_CID_POWER_LINE_FREQUENCY_60HZ = 2, > > > +}; > > > +#define V4L2_CID_HUE_AUTO (V4L2_CID_BASE+25) > > > +#define V4L2_CID_WHITE_BALANCE_TEMPERATURE (V4L2_CID_BASE+26) > > > +#define V4L2_CID_SHARPNESS (V4L2_CID_BASE+27) > > > +#define V4L2_CID_BACKLIGHT_COMPENSATION (V4L2_CID_BASE+28) > > > +#define V4L2_CID_LASTP1 (V4L2_CID_BASE+29) /* last CID + 1 */ > > > > > > /* MPEG-class control IDs defined by V4L2 */ > > > #define V4L2_CID_MPEG_BASE (V4L2_CTRL_CLASS_MPEG | 0x900) > > > > Also, please, remove trailing blanks in 7 lines: > > > > Adds trailing whitespace. > > .dotest/patch:26:#define V4L2_CID_HCENTER_DEPRECATED (V4L2_CID_BASE+22) > > Adds trailing whitespace. > > .dotest/patch:27:#define V4L2_CID_VCENTER_DEPRECATED (V4L2_CID_BASE+23) > > Adds trailing whitespace. > > .dotest/patch:29:#define V4L2_CID_POWER_LINE_FREQUENCY (V4L2_CID_BASE+24) > > Adds trailing whitespace. > > .dotest/patch:35:#define V4L2_CID_HUE_AUTO (V4L2_CID_BASE+25) > > Adds trailing whitespace. > > .dotest/patch:36:#define V4L2_CID_WHITE_BALANCE_TEMPERATURE (V4L2_CID_BASE+26) > > warning: squelched 2 whitespace errors > > warning: 7 lines add whitespace errors. > > > > (git only listed 5 out of 7 lines explicitly above) > > Sorry about that, I am used to git and quilt checking for me :) > > Mauro: the patches have been updated here http://ifup.org/hg/v4l-spec Committed. > > For future reference here is a commit hook that I stole from git to > check for trailing whitespace. > http://ifup.org/~philips/hg-pre-commit You should use "make commit". It calls some scripts that strips bad whitespaces, checks CodingStyle violations, re-generates Documentation/video4linux/CARDLIST.*, ... The patch above has one intesting thing: it checks for merge conflicts. Maybe we can add this also to make commit scripts. Cheers, Mauro -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list