Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JNF2r-00072o-Nq for mharc-grub-devel@gnu.org; Thu, 07 Feb 2008 17:16:37 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JNF2q-000727-9z for grub-devel@gnu.org; Thu, 07 Feb 2008 17:16:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JNF2p-00071v-Cy for grub-devel@gnu.org; Thu, 07 Feb 2008 17:16:35 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JNF2p-00071s-7P for grub-devel@gnu.org; Thu, 07 Feb 2008 17:16:35 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JNF2o-0003GI-UB for grub-devel@gnu.org; Thu, 07 Feb 2008 17:16:35 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JNF2l-0005GS-Hd for grub-devel@gnu.org; Thu, 07 Feb 2008 23:16:34 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JNF10-0001kV-Ot for grub-devel@gnu.org; Thu, 07 Feb 2008 23:14:42 +0100 Date: Thu, 7 Feb 2008 23:14:42 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080207221442.GB23492@thorin> References: <47AB72B4.2070909@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47AB72B4.2070909@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Large image file support for grub-fstest X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2008 22:16:36 -0000 On Thu, Feb 07, 2008 at 10:05:56PM +0100, Christian Franke wrote: > The new command "grub-fstest" may not work for large image files or > /dev/sdX devices on 32-bit platforms. > > Legacy C89 functions fseek() and ftell() always use "long" as offset > type. The attached patch changes this to fseeko() and ftello() which use > off_t. These are part of POSIX, so new ./configure stuff should be not > necessary. > > Christian > > 2008-02-07 Christian Franke > > * util/hostfs.c (grub_hostfs_open): Use fseeko and ftello > instead of fseek and ftell to support large files. > (grub_hostfs_read): Likewise. Committed, thanks. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)