From: Kim Phillips Date: Mon, 11 Feb 2008 13:11:23 -0600 Subject: [U-Boot-Users] [PATCH v2] MPC85xx, MPC83xx: Add/Fix UPM configuration support In-Reply-To: References: <15338111.post@talk.nabble.com> <20080207163222.aae26900.kim.phillips@freescale.com> Message-ID: <20080211131123.7d457eb5.kim.phillips@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 10 Feb 2008 15:14:45 +0200 David Saada wrote: > > ack on the 83xx change, but the 85xx code looks identical to the 83xx > > version, and 86xx bits should be identical, too, so we would be better > > off refraining from triplicating code again and find a more common > > place to put this. Jon? Andy? > Definitely true, but that's a delicate change. For instance, this UPM > patch has the same logics for the 83xx & 85xx platforms, but the > registers are different. Unifying this code should result in lots of > ugly ifdefs. which registers are different? Kim