From: Wolfgang Denk Date: Wed, 13 Feb 2008 23:50:59 +0100 Subject: [U-Boot-Users] [PATCH][ARM] Rationalize ARM compiler options In-Reply-To: Your message of "Wed, 13 Feb 2008 15:55:00 GMT." <1202918100.6285.8.camel@us710-oe.cambridge.arm.com> Message-ID: <20080213225100.0CF0324050@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <1202918100.6285.8.camel@us710-oe.cambridge.arm.com> you wrote: > Signed-off-by: Peter Pearse > --- > diff --git a/cpu/arm1136/config.mk b/cpu/arm1136/config.mk > old mode 100644 > new mode 100755 > index 6ab0dd3..5c64aa7 > --- a/cpu/arm1136/config.mk > +++ b/cpu/arm1136/config.mk > @@ -2,6 +2,7 @@ > # (C) Copyright 2002 > # Gary Jennejohn, DENX Software Engineering, > # > +# > # See file CREDITS for list of people who contributed to this Please don't add too many empty lines. > # project. > # > @@ -20,16 +21,15 @@ > # Foundation, Inc., 59 Temple Place, Suite 330, Boston, > # MA 02111-1307 USA > # > -PLATFORM_RELFLAGS += -fno-strict-aliasing -fno-common -ffixed-r8 \ > - -msoft-float > +# ========================================================================= > +# See doc/README.ARM.config.mk for a justification of the ARM specific options > +# ========================================================================= > +PLATFORM_RELFLAGS += -fno-strict-aliasing -fno-common -ffixed-r8 Why exactly are you dropping -msoft-float here? > -# Make ARMv5 to allow more compilers to work, even though its v6. > -PLATFORM_CPPFLAGS += -march=armv5 > +PLATFORM_CPPFLAGS += -march=armv6 Why exactly are you changing this? > --- a/cpu/arm720t/config.mk > +++ b/cpu/arm720t/config.mk > @@ -21,15 +21,15 @@ > # Foundation, Inc., 59 Temple Place, Suite 330, Boston, > # MA 02111-1307 USA > # > +# ========================================================================= > +# See doc/README.ARM.config.mk for a justification of the ARM specific options > +# ========================================================================= > +PLATFORM_RELFLAGS += -fno-strict-aliasing -fno-common -ffixed-r8 > > -PLATFORM_RELFLAGS += -fno-strict-aliasing -fno-common -ffixed-r8 \ > - -msoft-float > - > -PLATFORM_CPPFLAGS += -march=armv4 -mtune=arm7tdmi > +PLATFORM_CPPFLAGS += -march=armv4t > # ========================================================================= > -# > # Supply options according to compiler version > -# > # ========================================================================= > PLATFORM_CPPFLAGS +=$(call cc-option,-mapcs-32,-mabi=apcs-gnu) > PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,)) > + Please don't add trailing empty lines. > old mode 100644 > new mode 100755 > index 8db4adb..b5605b3 > --- a/cpu/arm920t/config.mk > +++ b/cpu/arm920t/config.mk > @@ -2,6 +2,7 @@ > # (C) Copyright 2002 > # Gary Jennejohn, DENX Software Engineering, > # > +# Please don't add random empty lines. etc. etc. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There is is no reason for any individual to have a computer in their home. -- Ken Olsen (President of Digital Equipment Corporation), Convention of the World Future Society, in Boston, 1977