From: Wolfgang Denk Date: Thu, 14 Feb 2008 01:39:14 +0100 Subject: [U-Boot-Users] [PATCH] Extend ATI Radeon driver to support more video modes In-Reply-To: Your message of "Thu, 14 Feb 2008 00:51:19 +0100." <47B38277.6010001@denx.de> Message-ID: <20080214003914.1F01524050@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <47B38277.6010001@denx.de> you wrote: > > >> +#if 1 /* @ 60 Hz */ > >> + mode->crtc_h_total_disp = 0x009f00d2; > >> + mode->crtc_h_sync_strt_wid = 0x000e0528; > >> + mode->crtc_v_total_disp = 0x03ff0429; > >> + mode->crtc_v_sync_strt_wid = 0x00030400; > >> + mode->crtc_pitch = 0x00a000a0; > >> + mode->ppll_div_3 = 0x00010060; > >> +#else /* @ 75 Hz */ > >> + mode->crtc_h_total_disp = 0x009f00d2; > >> + mode->crtc_h_sync_strt_wid = 0x00120508; > >> + mode->crtc_v_total_disp = 0x03ff0429; > >> + mode->crtc_v_sync_strt_wid = 0x00030400; > >> + mode->crtc_pitch = 0x00a000a0; > >> + mode->ppll_div_3 = 0x00010078; > >> +#endif > > > > Mmm... better adding a configuration define here or just remove the > > unused code. > > Ok, I'm going to drop the unused code then. No, please keep it as reference in case anybody needs this later. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Man did not weave the web of life; he is merely a strand in it. Whatever he does to the web, he does to himself. - Seattle [1854]