Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JSSei-0000FX-9m for mharc-grub-devel@gnu.org; Fri, 22 Feb 2008 02:49:16 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JSSef-0000Dn-Fs for grub-devel@gnu.org; Fri, 22 Feb 2008 02:49:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JSSee-0000DX-0X for grub-devel@gnu.org; Fri, 22 Feb 2008 02:49:12 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JSSed-0000DU-Q4 for grub-devel@gnu.org; Fri, 22 Feb 2008 02:49:11 -0500 Received: from bigbox.boeglin.org ([88.191.20.48]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JSSed-0005pP-E3 for grub-devel@gnu.org; Fri, 22 Feb 2008 02:49:11 -0500 Received: by bigbox.boeglin.org (Postfix, from userid 1000) id 946079408A; Fri, 22 Feb 2008 08:49:52 +0100 (CET) Date: Fri, 22 Feb 2008 08:49:52 +0100 From: Alexandre Boeglin To: The development of GRUB 2 Message-ID: <20080222074952.GA16785@boeglin.org> References: <20080217115240.GB8497@boeglin.org> <200802212208.56286.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <200802212208.56286.okuji@enbug.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Content-Transfer-Encoding: quoted-printable X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: [PATCH] fix GRUB_TICKS_PER_SECOND in include/grub/efi/time.h X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2008 07:49:14 -0000 Le jeu 21 f=E9v 2008 =E0 22:08:55 +0100, Yoshinori K. Okuji a =E9crit : > On Sunday 17 February 2008 12:52, Alexandre Boeglin wrote: > > This small patch fixes grub_get_rtc on EFI architecture. If I underst= ood > > correctly, one minute is 60000 milliseconds, not 3600. >=20 > Nope. What's wrong here is the comment but not the code. It should read= "This=20 > is destined to overflow when one hour passes by." Then, I think the problem is the same, as the current grub_get_rtc return= s a number of milliseconds. So, shouldn'it be 60 * 60 * 1000 ? Alex