Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JSTD2-00005x-6M for mharc-grub-devel@gnu.org; Fri, 22 Feb 2008 03:24:44 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JSTD0-00005q-7o for grub-devel@gnu.org; Fri, 22 Feb 2008 03:24:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JSTCy-00005d-Iu for grub-devel@gnu.org; Fri, 22 Feb 2008 03:24:41 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JSTCy-00005a-EO for grub-devel@gnu.org; Fri, 22 Feb 2008 03:24:40 -0500 Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JSTCy-0002A8-06 for grub-devel@gnu.org; Fri, 22 Feb 2008 03:24:40 -0500 Received: from ns39764.ovh.net ([91.121.25.85] helo=nexedi.com) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JSTCw-0003p0-Fq for grub-devel@gnu.org; Fri, 22 Feb 2008 03:24:38 -0500 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 346803D97D for ; Fri, 22 Feb 2008 09:32:30 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Fri, 22 Feb 2008 09:24:23 +0100 User-Agent: KMail/1.9.4 References: <20080217115240.GB8497@boeglin.org> <200802212208.56286.okuji@enbug.org> <20080222074952.GA16785@boeglin.org> In-Reply-To: <20080222074952.GA16785@boeglin.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200802220924.24766.okuji@enbug.org> X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] fix GRUB_TICKS_PER_SECOND in include/grub/efi/time.h X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2008 08:24:42 -0000 On Friday 22 February 2008 08:49, Alexandre Boeglin wrote: > Le jeu 21 f=E9v 2008 =E0 22:08:55 +0100, Yoshinori K. Okuji a =E9crit : > > On Sunday 17 February 2008 12:52, Alexandre Boeglin wrote: > > > This small patch fixes grub_get_rtc on EFI architecture. If I > > > understood correctly, one minute is 60000 milliseconds, not 3600. > > > > Nope. What's wrong here is the comment but not the code. It should read > > "This is destined to overflow when one hour passes by." > > Then, I think the problem is the same, as the current grub_get_rtc returns > a number of milliseconds. So, shouldn'it be 60 * 60 * 1000 ? No. Why do you think it returns milliseconds? Okuji