From: Arnd Bergmann Subject: Re: [RFC 01/11] add generic versions of debugfs file operations Date: Sun, 24 Feb 2008 11:46:07 +0100 Message-ID: <200802241146.08360.arnd@arndb.de> References: <20080219040435.825494460@arndb.de> <20080219040828.415218298@arndb.de> <20080223122444.GM27894@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Greg KH , David Howells To: Al Viro Return-path: Received: from moutng.kundenserver.de ([212.227.126.174]:61110 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbYBXKqX (ORCPT ); Sun, 24 Feb 2008 05:46:23 -0500 In-Reply-To: <20080223122444.GM27894@ZenIV.linux.org.uk> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Saturday 23 February 2008, Al Viro wrote: > Ewww - caps, \n... BTW, \0 is pointless here - simple_read_from_buffer() will > not access it with these arguments)... > ... > Please, check the length; sloppy input grammar is a bad idea. Hell, at the > very least you want -EINVAL if input is not recognized... Ok, these two come straight from debugfs, but of course I can fix them anyway. Should I do a fix for debugfs in 2.6.25 first, or rather do a patch on top of the libfs rework? I'd rather not have any semantic changes during the conversion, so it would be better to keep that separate imho. Arnd <><