From: Arnd Bergmann Subject: Re: [RFC 02/11] introduce simple_fs_type Date: Sun, 24 Feb 2008 11:55:52 +0100 Message-ID: <200802241155.53861.arnd@arndb.de> References: <20080219040435.825494460@arndb.de> <20080219040828.690045213@arndb.de> <20080223122859.GN27894@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Greg KH , David Howells To: Al Viro Return-path: Received: from moutng.kundenserver.de ([212.227.126.174]:62818 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751439AbYBXK4E (ORCPT ); Sun, 24 Feb 2008 05:56:04 -0500 In-Reply-To: <20080223122859.GN27894@ZenIV.linux.org.uk> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Saturday 23 February 2008, Al Viro wrote: > On Tue, Feb 19, 2008 at 05:04:37AM +0100, Arnd Bergmann wrote: > > The most interesting function here is the new "struct dentry * > > simple_register_filesystem(struct simple_fs_type *type)", which > > returns the root directory of a new file system that can then > > be passed to simple_create_file() and similar functions as a > > parent. > > Don't mix "split the file" with "add new stuff", please. Ok, I'll introduce it in libfs.c first then. > And frankly, I'm not convinced that embedding file_system_type > into another struct is a good idea. Right, that has been one of the areas I've been thinking about myself without coming to a good solution. One alternative I thought about is to have the news members as part of file_system_type itself, but that would cost a bit of memory for every single file system, and might lead to unintended misuse of these members by non-simple file systems. Do you think it would be better to dynamically allocate the file_system_type and have a pointer in struct simple_fs_type to it? Arnd <><