From: Christoph Egger Subject: [PATCH] Fix c/s 17104 Date: Mon, 25 Feb 2008 09:22:08 +0100 Message-ID: <200802250922.08405.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_wqnwHFOUeEaXnEY" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org --Boundary-00=_wqnwHFOUeEaXnEY Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Keir, Changeset 17104 does not look correct to me. svm_set_interrupt_shadow() seems to be a copy & paste bug, because the intr_shadow parameter is unused. I think, what you intended to do is the attached patch. That's all what I found so far just from reading the diff - but there may b= e=20 more. Please double-check. Signed-off-by: Christoph Egger =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=E4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=E4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=E4ftsf=FChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy --Boundary-00=_wqnwHFOUeEaXnEY Content-Type: text/x-diff; charset="iso-8859-1"; name="xen_svm.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen_svm.diff" diff -r 200787660b5f xen/arch/x86/hvm/svm/svm.c --- a/xen/arch/x86/hvm/svm/svm.c Fri Feb 22 18:32:41 2008 +0000 +++ b/xen/arch/x86/hvm/svm/svm.c Mon Feb 25 09:06:24 2008 +0100 @@ -375,7 +375,7 @@ static void svm_set_interrupt_shadow(str static void svm_set_interrupt_shadow(struct vcpu *v, unsigned int intr_shadow) { struct vmcb_struct *vmcb = v->arch.hvm_svm.vmcb; - vmcb->interrupt_shadow = !!(vmcb->interrupt_shadow & + vmcb->interrupt_shadow = !!(intr_shadow & (HVM_INTR_SHADOW_MOV_SS|HVM_INTR_SHADOW_STI)); } --Boundary-00=_wqnwHFOUeEaXnEY Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_wqnwHFOUeEaXnEY--