From: Ingo Molnar Subject: Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related? Date: Tue, 26 Feb 2008 12:29:32 +0100 Message-ID: <20080226112932.GB10996@elte.hu> References: <87wsovkth5.fsf@hades.wkstn.nix> <87skzipcpw.fsf@hades.wkstn.nix> <87oda6p9st.fsf@hades.wkstn.nix> <20080225123041.401da103.akpm@linux-foundation.org> <20080225224807.GA15700@atrey.karlin.mff.cuni.cz> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Jiri Kosina Cc: Jan Kara , Jan Kara , Peter Osterlund , linux-kernel@vger.kernel.org, Nix , dm-devel@redhat.com, Andrew Morton List-Id: dm-devel.ids * Jiri Kosina wrote: > + name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL); > + fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL); > + > + if (!name || !fname) { > + *err = -ENOMEM; > + return NULL; > + } > + > if (dentry) { > if (!dentry->d_name.len) { > *err = -EINVAL; this bit is missing i think: if (name) kfree(name); if (fname) kfree(fname); Ingo