From: Christoph Egger Subject: Re: [PATCH] Fix c/s 17104 Date: Thu, 28 Feb 2008 17:12:32 +0100 Message-ID: <200802281712.32307.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Monday 25 February 2008 10:03:18 Keir Fraser wrote: > Nice one. I didn't have a good coding afternoon on Friday. :-( > > In general the mmio (and other) emulation changes have had very little > testing on AMD, so please do test and let me know if anything else has > broken. Yes, there are MMIO problems. We tracked them down to changeset 17090. Christoph > > -- Keir > > On 25/2/08 08:22, "Christoph Egger" wrote: > > Hi Keir, > > > > Changeset 17104 does not look correct to me. > > svm_set_interrupt_shadow() seems to be a copy & paste bug, because > > the intr_shadow parameter is unused. > > I think, what you intended to do is the attached patch. > > That's all what I found so far just from reading the diff - but there m= ay > > be more. Please double-check. > > > > Signed-off-by: Christoph Egger =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=E4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=E4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=E4ftsf=FChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy