From: Simon Horman Subject: Re: [patch 0/5] kexec: Remove xen/common/compat/kexec.c Date: Fri, 29 Feb 2008 17:41:24 +0900 Message-ID: <20080229084122.GA20065@verge.net.au> References: <20080229062854.370669317@vergenet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Feb 29, 2008 at 07:34:41AM +0000, Keir Fraser wrote: > On 29/2/08 06:28, "Simon Horman" wrote: > > > as discussed briefly on xen-devel, the method of defining compat > > functions for kexec involves a two-phase build of xen/common/kexec.c, > > hinging around the inclusion of xen/common/compat/kexec.c. > > > > This series of patches systematically removes any need for > > xen/common/compat/kexec.c and then removes xen/common/compat/kexec.c > > itself. > > Thanks, I'll take a look. It looks like it's not really a reduction in code > size, but is rather less likely to make the readers brain bleed! More thought would be needed if lines of code reduction is desired, though I think that the size of the output of the compile might be slightly smaller. It does however seem to make things less bleed prone :-) I noticed a slight problem with compiling without CONFIG_COMPAT after lunch. I have posted my update to the relevant patch. -- Horms