Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JV4h6-0006Uh-Qr for mharc-grub-devel@gnu.org; Fri, 29 Feb 2008 07:50:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JV4h4-0006RG-Gd for grub-devel@gnu.org; Fri, 29 Feb 2008 07:50:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JV4h2-0006Q0-9A for grub-devel@gnu.org; Fri, 29 Feb 2008 07:50:29 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JV4h2-0006Px-7H for grub-devel@gnu.org; Fri, 29 Feb 2008 07:50:28 -0500 Received: from bigbox.boeglin.org ([88.191.20.48]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JV4h1-0001Nj-Rg for grub-devel@gnu.org; Fri, 29 Feb 2008 07:50:28 -0500 Received: by bigbox.boeglin.org (Postfix, from userid 1000) id AB7CE9408A; Fri, 29 Feb 2008 13:52:40 +0100 (CET) Date: Fri, 29 Feb 2008 13:52:40 +0100 From: Alexandre Boeglin To: The development of GRUB 2 Message-ID: <20080229125240.GA13522@boeglin.org> References: <20080217115240.GB8497@boeglin.org> <200802212208.56286.okuji@enbug.org> <20080222074952.GA16785@boeglin.org> <200802220924.24766.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <200802220924.24766.okuji@enbug.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Content-Transfer-Encoding: quoted-printable X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: [PATCH] fix GRUB_TICKS_PER_SECOND in include/grub/efi/time.h X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Feb 2008 12:50:31 -0000 Le ven 22 f=E9v 2008 =E0 09:24:23 +0100, Yoshinori K. Okuji a =E9crit : > > Then, I think the problem is the same, as the current grub_get_rtc re= turns > > a number of milliseconds. So, shouldn'it be 60 * 60 * 1000 ? >=20 > No. Why do you think it returns milliseconds? Ah, it does not exactly "return" milliseconds, sorry. But currently it se= ems GRUB_TICKS_PER_SECOND "overflows" a value in milliseconds, so I think it should use milliseconds and not seconds as its "base". Alex