From: Andreas Dilger Subject: Re: new_block error Date: Fri, 29 Feb 2008 12:44:00 -0800 Message-ID: <20080229204400.GP2997@webber.adilger.int> References: <1204224350.16889.30.camel@worker.quietwind.net> <1204237379.3609.7.camel@localhost.localdomain> <1204243811.16889.53.camel@worker.quietwind.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Cc: cmm@us.ibm.com, linux-fsdevel@vger.kernel.org To: Chris Kottaridis Return-path: Received: from sca-es-mail-1.Sun.COM ([192.18.43.132]:42129 "EHLO sca-es-mail-1.sun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933629AbYB2UoE (ORCPT ); Fri, 29 Feb 2008 15:44:04 -0500 Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m1TKi3Eh001590 for ; Fri, 29 Feb 2008 12:44:04 -0800 (PST) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JX000901PHUPV00@fe-sfbay-09.sun.com> (original mail from adilger@sun.com) for linux-fsdevel@vger.kernel.org; Fri, 29 Feb 2008 12:44:03 -0800 (PST) In-reply-to: <1204243811.16889.53.camel@worker.quietwind.net> Content-disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Feb 28, 2008 17:10 -0700, Chris Kottaridis wrote: > That's all I currently have of the log, I'll see if I can get more of > it. > > I was pointed to this diff that has a "goto out" added if we hit this > scenario: > > feda58d37ae0efe22e711a74e26fb541d4eb1baa > fs/ext3/balloc.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c > index a26e683..d2dface 100644 > --- a/fs/ext3/balloc.c > +++ b/fs/ext3/balloc.c > @@ -530,11 +530,13 @@ do_more: > in_range (block, le32_to_cpu(desc->bg_inode_table), > sbi->s_itb_per_group) || > in_range (block + count - 1, le32_to_cpu(desc->bg_inode_table), > - sbi->s_itb_per_group)) > + sbi->s_itb_per_group)) { > ext3_error (sb, "ext3_free_blocks", > "Freeing blocks in system zones - " > "Block = "E3FSBLK", count = %lu", > block, count); > + goto error_return; > + } > > /* > * We are about to start releasing blocks in the bitmap, > @@ -1637,11 +1639,13 @@ allocated: > in_range(ret_block, le32_to_cpu(gdp->bg_inode_table), > EXT3_SB(sb)->s_itb_per_group) || > in_range(ret_block + num - 1, le32_to_cpu(gdp->bg_inode_table), > - EXT3_SB(sb)->s_itb_per_group)) > + EXT3_SB(sb)->s_itb_per_group)) { > ext3_error(sb, "ext3_new_block", > "Allocating block in system zone - " > "blocks from "E3FSBLK", length %lu", > ret_block, num); > + goto out; > + } > > performed_allocation = 1; Are these patches in the upstream kernel yet? I'd submitted fixes like this for 2.4 kernels, but it never seems to make it into the kernel for 2.6... Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.