From: Wolfgang Denk Date: Tue, 25 Mar 2008 13:37:36 +0100 Subject: [U-Boot-Users] [PATCH] DM644x: (2nd try) This patch removes all boardspecific code from the arch. part for DM644x (DaVinci) boards In-Reply-To: Your message of "Tue, 25 Mar 2008 10:24:20 +0100." <4CD35CD1F8085945B597F80EEC8942138A24A6@exc01.bk.prodrive.nl> Message-ID: <20080325123736.EF49A243A7@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <4CD35CD1F8085945B597F80EEC8942138A24A6@exc01.bk.prodrive.nl> you wrote: > > --- a/cpu/arm926ejs/davinci/lowlevel_init.S > +++ b/cpu/arm926ejs/davinci/lowlevel_init.S > @@ -3,6 +3,11 @@ > * > * Copyright (C) 2007 Sergey Kubushyn > * > + * Copyright (C) 2008 Prodrive BV > + * Changed: > + * Made board specific defines such as DDR timing and PLL > + * dividers. These should be set in the board config file > + * > * Partially based on TI sources, original copyrights follow: > */ Please don't add changelog information to source code. > diff --git a/cpu/arm926ejs/davinci/nand.c b/cpu/arm926ejs/davinci/nand.c > index 127be9f..3257f83 100644 > --- a/cpu/arm926ejs/davinci/nand.c > +++ b/cpu/arm926ejs/davinci/nand.c ... > + /* All EMIF initialization is done in lowlevel_init.S > + * and config values are in the board config files > + */ This is not the correct style for multi-line comments. The "/*" goes on a line for it's own. > diff --git a/include/configs/davinci_dvevm.h b/include/configs/davinci_dvevm.h > index 8ecd059..5557723 100644 > --- a/include/configs/davinci_dvevm.h > +++ b/include/configs/davinci_dvevm.h > @@ -52,6 +52,9 @@ > #define DV_EVM > #define CFG_NAND_SMALLPAGE > #define CFG_USE_NOR > +#define CFG_USE_INTEL_NOR /* Define this when your DVEVM has Intel > + * flash instead of AMD flash > + */ Ditto. J. has commented on this before!!! > -----Original Message----- > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] > Sent: zaterdag 22 maart 2008 14:23 > To: Pieter Voorthuijsen > Cc: u-boot-users at lists.sourceforge.net > Subject: Re: [PATCH] DM644x: (2nd try) This patch removes all boardspecific code from the arch. part for DM644x (DaVinci) boards And PLEASE - never top post full quote!!!! Especially not when including patches!!! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Many companies that have made themselves dependent on [the equipment of a certain major manufacturer] (and in doing so have sold their soul to the devil) will collapse under the sheer weight of the un- mastered complexity of their data processing systems. -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5