From: Arnd Bergmann Subject: Re: [PATCH 2/7] omfs: add inode routines Date: Fri, 28 Mar 2008 04:42:45 +0100 Message-ID: <200803280442.45974.arnd@arndb.de> References: <1206578760-9050-2-git-send-email-me@bobcopeland.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Bob Copeland Return-path: Received: from moutng.kundenserver.de ([212.227.126.177]:49537 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbYC1DnB convert rfc822-to-8bit (ORCPT ); Thu, 27 Mar 2008 23:43:01 -0400 In-Reply-To: <1206578760-9050-2-git-send-email-me@bobcopeland.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thursday 27 March 2008, Bob Copeland wrote: > +static struct inode *omfs_alloc_inode(struct super_block *sb) > +{ > +=A0=A0=A0=A0=A0=A0=A0struct omfs_inode_info *oinf; > +=A0=A0=A0=A0=A0=A0=A0oinf =3D (struct omfs_inode_info *) kmem_cache_= alloc(omfs_inode_cachep, > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= GFP_KERNEL); > +=A0=A0=A0=A0=A0=A0=A0if (!oinf) > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return NULL; > +=A0=A0=A0=A0=A0=A0=A0return &oinf->vfs_inode; > +} If you could avoid the i_state member in omfs_inode_info, you could get rid of your own inode cache entirely. Your i_state seems to be mostly write-only, why is it needed in your file system? Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html