From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH][TOOLS] pygrub: cleanup and support for NetBSD
Date: Fri, 28 Mar 2008 10:34:16 +0100
Message-ID: <200803281034.16886.Christoph.Egger@amd.com>
References: <C4125045.157E2%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <C4125045.157E2%keir.fraser@eu.citrix.com>
Content-Disposition: inline
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: INAKOSHI Hiroya <inakoshi.hiroya@jp.fujitsu.com>, xen-devel@lists.xensource.com

On Friday 28 March 2008 08:35:33 Keir Fraser wrote:
> Fixed as changeset 17314.

I can confirm this fix is correct. I don't know how this could slip through=
=20
when I submitted the patch. Sorry for that.

Christoph

>
>  -- Keir
>
> On 28/3/08 07:26, "INAKOSHI Hiroya" <inakoshi.hiroya@jp.fujitsu.com> wrot=
e:
> > Hi Christoph,
> >
> > your patch made my linux guest unbootable.  Here is the xend.log.
> >
> > Regards,
> > Hiroya
> >
> > 2008-03-28 16:11:07 4582] DEBUG (XendDomainInfo:2279)
> > XendDomainInfo.destroy: domid=3D1
> > [2008-03-28 16:11:07 4582] DEBUG (XendDomainInfo:2296)
> > XendDomainInfo.destroyDomain(1)
> > [2008-03-28 16:11:07 4582] DEBUG (XendDomainInfo:1857) No device model
> > [2008-03-28 16:11:07 4582] DEBUG (XendDomainInfo:1859) Releasing devices
> > [2008-03-28 16:11:07 4582] ERROR (SrvBase:88) Request start failed.
> > Traceback (most recent call last):
> >   File "//usr/lib/python/xen/web/SrvBase.py", line 85, in perform
> >     return op_method(op, req)
> >   File "//usr/lib/python/xen/xend/server/SrvDomain.py", line 77, in
> > op_start return self.xd.domain_start(self.dom.getName(), paused)
> >   File "//usr/lib/python/xen/xend/XendDomain.py", line 1030, in
> > domain_start dominfo.start(is_managed =3D True)
> >   File "//usr/lib/python/xen/xend/XendDomainInfo.py", line 420, in start
> >     XendTask.log_progress(31, 60, self._initDomain)
> >   File "//usr/lib/python/xen/xend/XendTask.py", line 209, in log_progre=
ss
> >     retval =3D func(*args, **kwds)
> >   File "//usr/lib/python/xen/xend/XendDomainInfo.py", line 2046, in
> > _initDomain
> >     self._configureBootloader()
> >   File "//usr/lib/python/xen/xend/XendDomainInfo.py", line 2446, in
> > _configureBootloader
> >     bootloader_args, kernel, ramdisk, args)
> >   File "//usr/lib/python/xen/xend/XendBootloader.py", line 70, in
> > bootloader termios.tcsetattr(m1, termios.TCSANOW, attr)
> > NameError: global name 'attr' is not defined
> >
> > Christoph Egger wrote:
> >> Hi Keir,
> >>
> >> Attached patch gets rid of the global attr variable and adds support f=
or
> >> NetBSD.
> >>
> >> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> >>
> >>
> >> ----------------------------------------------------------------------=
=2D-
> >>
> >> _______________________________________________
> >> Xen-devel mailing list
> >> Xen-devel@lists.xensource.com
> >> http://lists.xensource.com/xen-devel
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel


=2D-=20
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Gesch=E4ftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplement=E4r:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Gesch=E4ftsf=FChrer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy