From: Hollis Blanchard Date: Wed, 02 Apr 2008 18:32:13 +0000 Subject: Re: [kvm-ppc-devel] Message-Id: <200804021332.13941.hollisb@us.ibm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: kvm-ppc@vger.kernel.org On Wednesday 02 April 2008 12:09:40 Jerone Young wrote: > On Wed, 2008-04-02 at 08:14 -0400, Jimi Xenidis wrote: > > On Apr 2, 2008, at 3:52 AM, Jerone Young wrote: > > > +void ppc4xx_idle(void) > > > +{ > > > +=A0=A0=A0unsigned long msr_save; > > > + > > > +=A0=A0=A0/* set wait state MSR */ > > > +=A0=A0=A0msr_save =3D mfmsr(); > > > +=A0=A0=A0mtmsr(msr_save|MSR_WE|MSR_EE|MSR_CE); > > > > 1) I think you also want MSR_DE here, no? > > 2) Just to be safe, I'd also append an isync(); > > 3) In case MSR_WE does nothing, or continues from here I'd append =A0 > > "mstmsr(msr_save); isync();" as well > > Looks like using local_irq_enable() just might have been a better idea > after all. Doesn't look that way to me. > So the MSR_DE is yet another case that could go here. If it was on > coming into power_save...I'm assuming it would get disabled by > local_irq_disable(). This is not the case. Please look it up if you have any question. --=20 Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ kvm-ppc-devel mailing list kvm-ppc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel