From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [patch 0/15] LogFS take five Date: Mon, 7 Apr 2008 11:10:47 +0200 Message-ID: <20080407091047.GD22431@logfs.org> References: <20080401181308.512473173@logfs.org> <20080404114600.GD29686@kernel.dk> <20080407082235.GB22431@logfs.org> <20080407082841.GL12774@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, Nick Piggin , David Woodhouse To: Jens Axboe Return-path: Received: from lazybastard.de ([212.112.238.170]:47632 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756684AbYDGJK4 (ORCPT ); Mon, 7 Apr 2008 05:10:56 -0400 Content-Disposition: inline In-Reply-To: <20080407082841.GL12774@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 7 April 2008 10:28:41 +0200, Jens Axboe wrote: > >=20 > > fs/block_dev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > --- linux-2.6.24logfs/fs/block_dev.c~blockdev_nofs 2008-04-07 10:19= :08.627413077 +0200 > > +++ linux-2.6.24logfs/fs/block_dev.c 2008-04-07 10:20:56.927117162 = +0200 > > @@ -586,7 +586,7 @@ struct block_device *bdget(dev_t dev) > > inode->i_rdev =3D dev; > > inode->i_bdev =3D bdev; > > inode->i_data.a_ops =3D &def_blk_aops; > > - mapping_set_gfp_mask(&inode->i_data, GFP_USER); > > + mapping_set_gfp_mask(&inode->i_data, GFP_USER & ~__GFP_FS); > > inode->i_data.backing_dev_info =3D &default_backing_dev_info; > > spin_lock(&bdev_lock); > > list_add(&bdev->bd_list, &all_bdevs); >=20 > It's not the right fix, generally GFP_FS is fine here. So do that in > logfs when you cannot traverse back into the fs, eg >=20 > mapping_gfp_mask(mapping) & ~__GFP_FS; >=20 > locally. struct address_space *mapping; /* Prevent bdev from calling back into fs */ mapping =3D &logfs_super(sb)->s_bdev->bd_inode->i_data; mapping_set_gfp_mask(mapping, mapping_gfp_mask(mapping) & ~__GFP_FS); bd_inode has an interesting comment: struct inode * bd_inode; /* will die */ Should I be worried about that? It seems to predate git history, so I'm not too concerned about immediate changes. J=C3=B6rn --=20 Unless something dramatically changes, by 2015 we'll be largely wondering what all the fuss surrounding Linux was really about. -- Rob Enderle -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html