From: Christoph Hellwig Subject: Re: [PATCH 3/7] omfs: add directory routines Date: Sun, 13 Apr 2008 05:20:23 -0400 Message-ID: <20080413092023.GA19626@infradead.org> References: <1208041121-26787-4-git-send-email-me@bobcopeland.com> <20080413101144.4d496e9d@core> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Bob Copeland , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org To: Alan Cox Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:54707 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755697AbYDMJUc (ORCPT ); Sun, 13 Apr 2008 05:20:32 -0400 Content-Disposition: inline In-Reply-To: <20080413101144.4d496e9d@core> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Apr 13, 2008 at 10:11:44AM +0100, Alan Cox wrote: > > > +static int omfs_readdir(struct file *filp, void *dirent, filldir_t filldir) > > +{ > > + struct inode *dir = filp->f_dentry->d_inode; > > + struct buffer_head *bh = NULL; > > > + if (filp->f_pos >> 32) > > + goto success; > > f_pos may be 32bit in which case >> 32 does not have defined behaviour in > C. f_pos is always 64bit since 2.3.x