From: Alan Cox Subject: Re: [PATCH 3/7] omfs: add directory routines Date: Sun, 13 Apr 2008 10:11:44 +0100 Message-ID: <20080413101144.4d496e9d@core> References: <1208041121-26787-4-git-send-email-me@bobcopeland.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, Bob Copeland To: Bob Copeland Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:36602 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753666AbYDMJQH (ORCPT ); Sun, 13 Apr 2008 05:16:07 -0400 In-Reply-To: <1208041121-26787-4-git-send-email-me@bobcopeland.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > +static int omfs_readdir(struct file *filp, void *dirent, filldir_t filldir) > +{ > + struct inode *dir = filp->f_dentry->d_inode; > + struct buffer_head *bh = NULL; > + if (filp->f_pos >> 32) > + goto success; f_pos may be 32bit in which case >> 32 does not have defined behaviour in C. Alan