From: Hollis Blanchard Date: Mon, 14 Apr 2008 20:45:27 +0000 Subject: Re: [kvm-ppc-devel] [PATCH] [2/3] kvmppc: full instruction Message-Id: <200804141545.27659.hollisb@us.ibm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: kvm-ppc@vger.kernel.org On Monday 14 April 2008 07:23:57 ehrhardt@linux.vnet.ibm.com wrote: > From: Christian Ehrhardt > > This adds a relayfs based kernel interface that allows tracing of all > emulated guest instructions. It is based on Hollis tracing of tlb > activities. A suitable userspace program to read from that interface and a > post processing script that give users a readable output follow. > This feature is configurable in .config under the kvmppc virtualization > itself. I'm not sure how I feel about logging *every* faulting instruction, rather = than aggregating statistics about them. Actually, I know how I feel, and it= 's=20 uncomfortable. :) It's a userspace process that must be extracting this data from the relay=20 buffers, and that only happens when it's scheduled. How many instruction=20 exits could we get in a few timeslices? I think we could easily overflow th= e=20 relay buffers, especially if the host is under load. > +struct instr_record { > +=A0=A0=A0=A0=A0=A0=A0u32 time; > +=A0=A0=A0=A0=A0=A0=A0u32 pc; > +=A0=A0=A0=A0=A0=A0=A0u32 instr; > +=A0=A0=A0=A0=A0=A0=A0u32 rsval; > +=A0=A0=A0=A0=A0=A0=A0u32 raval; > +=A0=A0=A0=A0=A0=A0=A0u32 rbval; > +}; In addition to the instruction itself, I can see how the PC would be useful= ,=20 and maybe also the time when we have multiple cores. (Well, or maybe it wou= ld=20 be better to have one channel per core anyways.) But I think RS/RA/RB are w= ay=20 overkill here. What would a userspace tool do with this data anyways? --=20 Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference=20 Don't miss this year's exciting event. There's still time to save $100.=20 Use priority code J8TL2D2.=20 http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/java= one _______________________________________________ kvm-ppc-devel mailing list kvm-ppc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel