From: Arnd Bergmann Date: Mon, 14 Apr 2008 14:39:30 +0000 Subject: Re: [kvm-ppc-devel] [PATCH] [3/3] kvmppc: make tlb tracing Message-Id: <200804141639.30920.arnd@arndb.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: kvm-ppc@vger.kernel.org On Monday 14 April 2008, ehrhardt@linux.vnet.ibm.com wrote: > @@ -58,6 +58,14 @@ config KVM_POWERPC_440_TRACE_INSTRUCTION > =A0=A0=A0=A0=A0=A0=A0=A0 =A0channel. > =A0=A0=A0=A0=A0=A0=A0=A0 =A0If unsure, say N. > =A0 > +config KVM_POWERPC_440_TRACE_TLB > +=A0=A0=A0=A0=A0=A0=A0bool "ppc440 guest tlb activity tracing" > +=A0=A0=A0=A0=A0=A0=A0depends on KVM && 44x && KVM_POWERPC_440 > +=A0=A0=A0=A0=A0=A0=A0select RELAY > +=A0=A0=A0=A0=A0=A0=A0---help--- > +=A0=A0=A0=A0=A0=A0=A0 =A0Adds the complete tracing of the tlb activities= via a relayfs channel. > +=A0=A0=A0=A0=A0=A0=A0 =A0If unsure, say N. > + I think you're taking the configurability a little too far, do you really want users to be able to select the three new tracing options separately? Choosing between all stats and no stats at all sounds sufficient to me. Arnd <>< ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference=20 Don't miss this year's exciting event. There's still time to save $100.=20 Use priority code J8TL2D2.=20 http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/java= one _______________________________________________ kvm-ppc-devel mailing list kvm-ppc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel