From: Wolfgang Denk Date: Mon, 14 Apr 2008 21:50:49 +0200 Subject: [U-Boot-Users] [PATCH v2 3/7] add an i2c driver for mx31 In-Reply-To: Your message of "Mon, 14 Apr 2008 08:46:59 +0200." <20080414064659.GB17663@game.jcrosoft.org> Message-ID: <20080414195049.D198D248B9@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <20080414064659.GB17663@game.jcrosoft.org> you wrote: > > > +#if defined(CONFIG_HARD_I2C) && defined (CONFIG_I2C_MXC) > Please stop to define this here, move it the Makefile Hm... While I agree with the simple standard case of a single "#ifdef", I'm not so 100% sure it is a good thing to add such complex expressions to the Makefile. Aren't we just moving the #ifdef hell from one place to another? > Wolfgang, > Is it possible to NACK all patch that add new driver that do this You mean, automatically? I would not know how to do that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Deliver yesterday, code today, think tomorrow."