From: Sascha Hauer Date: Mon, 12 May 2008 15:27:55 +0200 Subject: [U-Boot-Users] [Patch] U-Boot-V2: parser.c sparse cleanup In-Reply-To: <8E8BB316C604E94AA019A54D0A5A82A201A2D399@dlee13.ent.ti.com> References: <8E8BB316C604E94AA019A54D0A5A82A201A2D399@dlee13.ent.ti.com> Message-ID: <20080512132755.GI4464@pengutronix.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 12, 2008 at 07:24:43AM -0500, Menon, Nishanth wrote: > This patch cleans up the parser error seen during simple parser compilation. > Please note that CFG_CMD_BOOTD is not defined at the moment, but leaving it for addition at a later point of time. > > Signed-off-by: Nishanth Menon > > Index: u-boot-v2.git/common/parser.c > =================================================================== > --- u-boot-v2.git.orig/common/parser.c 2008-05-08 17:36:18.000000000 -0500 > +++ u-boot-v2.git/common/parser.c 2008-05-08 17:43:27.000000000 -0500 > @@ -2,7 +2,7 @@ > #include > #include > > -int parse_line (char *line, char *argv[]) > +static int parse_line (char *line, char *argv[]) > { > int nargs = 0; > > @@ -265,7 +265,7 @@ > continue; > } > > -#if (CONFIG_COMMANDS & CFG_CMD_BOOTD) > +#if defined(CONFIG_COMMANDS) & defined(CONFIG_CMD_BOOTD) U-Boot v1 used to have a bitmask for enabled commands (CONFIG_COMMANDS) and each command was represented by one bit, hence the construct above. We don't have this anymore and I think that this recursion stop does not work as expected anymore anyway, so you can remove this completely. Sascha -- Pengutronix e.K. - Linux Solutions for Science and Industry ----------------------------------------------------------- Kontakt-Informationen finden Sie im Header dieser Mail oder auf der Webseite -> http://www.pengutronix.de/impressum/ <-