From: Andreas Dilger Subject: Re: [PATCH 2/5] ocfs2: fiemap support Date: Sun, 25 May 2008 01:40:48 -0600 Message-ID: <20080525074048.GI3516@webber.adilger.int> References: <20080525000205.GL8325@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Cc: linux-fsdevel@vger.kernel.org To: Mark Fasheh Return-path: Received: from sca-es-mail-2.Sun.COM ([192.18.43.133]:40606 "EHLO sca-es-mail-2.sun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbYEYHkx (ORCPT ); Sun, 25 May 2008 03:40:53 -0400 Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m4P7eqjX006059 for ; Sun, 25 May 2008 00:40:52 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0K1E00H01YEGRX00@fe-sfbay-09.sun.com> (original mail from adilger@sun.com) for linux-fsdevel@vger.kernel.org; Sun, 25 May 2008 00:40:51 -0700 (PDT) In-reply-to: <20080525000205.GL8325@wotan.suse.de> Content-disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On May 24, 2008 17:02 -0700, Mark Fasheh wrote: > +int ocfs2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > + u64 map_start, u64 map_len) > +{ > + int ret, is_last; > + u32 mapping_end, cpos; > + unsigned int hole_size; > + struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); > + u64 len_bytes, phys_bytes, virt_bytes; > + struct buffer_head *di_bh = NULL; > + struct ocfs2_extent_rec rec; > + > + if (fieinfo->fi_flags & FIEMAP_FLAG_XATTR) { > + fieinfo->fi_flags = FIEMAP_FLAG_XATTR; > + return -EBADR; > + } This actually needs to check for every flag it DOES understand, otherwise it would break as soon as a new flag is added, per my comment in the VFS patch email. #define OCFS2_FIEMAP_FLAG_SUPP (FIEMAP_FLAG_NUM_EXTENTS | FIEMAP_FLAG_SYNC |\ FIEMAP_FLAG_HSM_READ | FIEMAP_FLAG_LUN_ORDER) if (fieinfo->fi_flags & ~OCFS2_FIEMAP_FLAG_SUPP) { fieinfo->fi_flags &= ~OCFS_FIEMAP_FLAG_SUPP; return -EBADR; } Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.