From: Christoph Hellwig Subject: Re: [patch 2/8] vfs: fix sys_getcwd for detached mounts Date: Sat, 31 May 2008 04:20:52 -0400 Message-ID: <20080531082052.GC24135@infradead.org> References: <20080529113245.450308367@szeredi.hu> <20080529113309.365088543@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org, John Johansen To: Miklos Szeredi Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:37368 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbYEaIUw (ORCPT ); Sat, 31 May 2008 04:20:52 -0400 Content-Disposition: inline In-Reply-To: <20080529113309.365088543@szeredi.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, May 29, 2008 at 01:32:47PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Currently getcwd(2) on a detached mount will give a garbled result: > > > mkdir /mnt/foo > > mount --bind /etc /mnt/foo > > cd /mnt/foo/skel > > /bin/pwd > /mnt/foo/skel > > umount -l /mnt/foo > > /bin/pwd > etcskel > > After the patch it will give a much saner "/skel" result. > > Thanks to John Johansen for pointing out this bug. I'm not sure just cuttinig of the prefix is perfect, but the previous behvaiour is obviously completely wrong, and the change is simple enough. So okay from me.