From: Christoph Hellwig Subject: Re: [patch 5/8] vfs: annotate permission operations Date: Sat, 31 May 2008 04:23:56 -0400 Message-ID: <20080531082356.GE24135@infradead.org> References: <20080529113245.450308367@szeredi.hu> <20080529113314.181992948@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:41091 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbYEaIX5 (ORCPT ); Sat, 31 May 2008 04:23:57 -0400 Content-Disposition: inline In-Reply-To: <20080529113314.181992948@szeredi.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, May 29, 2008 at 01:32:50PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Add more PERM_OP_ flags to permission() calls. This allows > filesystems like NFS and security modules like AppArmor to make > precise decisions about whent permissions need to be checked, and when > they will be checked later together with the actual operation. Where the heck does this PERM_OP crap come from? More MAY_ flags make sense in some cases, but we should introduce them on a per-need basis (e.g. to replace lookup intents in many cases), and without a new PERM_OP_ namespace.