From: Christoph Hellwig Subject: Re: [patch 8/8] vfs: create file_remove_suid() helper Date: Sat, 31 May 2008 04:29:34 -0400 Message-ID: <20080531082934.GG24135@infradead.org> References: <20080529113245.450308367@szeredi.hu> <20080529113318.257547449@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:46928 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbYEaI3f (ORCPT ); Sat, 31 May 2008 04:29:35 -0400 Content-Disposition: inline In-Reply-To: <20080529113318.257547449@szeredi.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, May 29, 2008 at 01:32:53PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > All calls to remove_suid() are made with a file pointer. This is not > accidental: similarly to file_update_time(), this function is called > when the file is written. > > So simplify callers by passing the file pointer instead of the dentry. It's not simplifying anything at all. You just move the pointer derefence down one step the callchain without any need.