From: Christoph Hellwig Subject: Re: [patch 8/8] vfs: create file_remove_suid() helper Date: Mon, 2 Jun 2008 02:05:09 -0400 Message-ID: <20080602060509.GA27519@infradead.org> References: <20080529113245.450308367@szeredi.hu> <20080529113318.257547449@szeredi.hu> <20080531082934.GG24135@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@infradead.org, linux-fsdevel@vger.kernel.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:38217 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbYFBGFJ (ORCPT ); Mon, 2 Jun 2008 02:05:09 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Jun 01, 2008 at 10:45:30PM +0200, Miklos Szeredi wrote: > Which means, that that pointer dereference will be done once instead > of in each caller, no? It's a gain (albeit a small one) is in code > cleanliness, and possibly in generated code size. Again, it doesn't make anyhing simpler. It might be a cleanup at best. I don't really care too much about this one because we could easily change it back in case a caller appear that just has the inode, but the tone you set here defintively doesn't help getting these trivial patches without real gain in :)