From: Mark Brown Subject: Re: [PATCH 1/3] ASoC: Add WM8510 driver Date: Thu, 5 Jun 2008 09:47:32 +0100 Message-ID: <20080605084732.GA30658@sirena.org.uk> References: <1212597211-14495-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20080604192455.GA10244@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id CEAF9245DF for ; Thu, 5 Jun 2008 10:47:33 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Brett Saunders , Geoffrey Wossum List-Id: alsa-devel@alsa-project.org On Wed, Jun 04, 2008 at 11:38:19PM +0200, Takashi Iwai wrote: > OK. I just wanted to confirm since the patch had no extra From: line > although the comment in the code shows Liam as the author. Ideally we'd be able to merge the full history. > This is likely superfluous. > > +#include > Ditto. Needed for SNDRV_DEFAULT_IDX1 and SNDRV_DEFAULT_STR1. > > + codec->reg_cache_size = sizeof(wm8510_reg); > Isn't this ARRAY_SIZE()? Looks like the all codec codes set the wrong > values for this... Not all, but most.